You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was added to work around some perceived shortcomings in svd2rust (see rust-embedded/svd2rust#213), and while I still think it would be worthwhile to make the proposed improvements in svd2rust, RegProxy causes a lot of complexity in this crate, and its utility is dubious at best.
The text was updated successfully, but these errors were encountered:
I think in it's current incarnation (ignoring the safety issues), RegProxy is of limited use. In syscon.rs it makes what's happening more clear, whilst in #210 it makes the code more complex & confusing.
Getting rid of RegProxy & replacing it with the unsafe equivalent, when it's used for shared registers (in ctimer, #210 and parts of dma) makes sense, but for the syscon it's seems fine if we just declare the constructor as unsafe.
It was added to work around some perceived shortcomings in svd2rust (see rust-embedded/svd2rust#213), and while I still think it would be worthwhile to make the proposed improvements in svd2rust,
RegProxy
causes a lot of complexity in this crate, and its utility is dubious at best.The text was updated successfully, but these errors were encountered: