Minor authentication issue #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed looking for AWS credentials from environment variables if they are not explicitly passed in. the AWS SDK for Node does a lot of magic of managing these credentials. When running this code in an ec2 instance or if we are just relying on default named credentials, this section causes the plugin to fail to authenticate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed looking for AWS credentials from environment variables if they are not explicitly passed in. the AWS SDK for Node does a lot of magic of managing these credentials. When running this code in an ec2 instance or if we are just relying on default named credentials, this section causes the plugin to fail to authenticate.