From 3a10e22b2a7693397abfda284542a141711802d0 Mon Sep 17 00:00:00 2001 From: leon Date: Fri, 6 Dec 2024 18:43:17 +0100 Subject: [PATCH] Add TODO comments to element_ids field for migration tracking --- athena/athena/models/db_modeling_feedback.py | 2 +- athena/athena/schemas/modeling_feedback.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/athena/athena/models/db_modeling_feedback.py b/athena/athena/models/db_modeling_feedback.py index 47d3a636..f7a6a5f3 100644 --- a/athena/athena/models/db_modeling_feedback.py +++ b/athena/athena/models/db_modeling_feedback.py @@ -11,7 +11,7 @@ class DBModelingFeedback(DBFeedback, Base): __tablename__ = "modeling_feedbacks" - element_ids: Optional[list[str]] = Column(JSON) # type: ignore + element_ids: Optional[list[str]] = Column(JSON) # type: ignore Todo: Remove after adding migrations to athena reference: Optional[str] = Column(String, nullable=True) # type: ignore exercise_id = Column(BigIntegerWithAutoincrement, ForeignKey("modeling_exercises.id", ondelete="CASCADE"), index=True) diff --git a/athena/athena/schemas/modeling_feedback.py b/athena/athena/schemas/modeling_feedback.py index 8b512353..99fae7ca 100644 --- a/athena/athena/schemas/modeling_feedback.py +++ b/athena/athena/schemas/modeling_feedback.py @@ -6,5 +6,5 @@ class ModelingFeedback(Feedback): """Feedback on a modeling exercise.""" - element_ids: Optional[List[str]] = Field([], description="referenced diagram element IDs", example=["id_1"]) + element_ids: Optional[List[str]] = Field([], description="referenced diagram element IDs", example=["id_1"]) # Todo: Remove after adding migrations to athena reference: Optional[str] = Field(None, description="reference to the diagram element", example="ClassAttribute:5a337bdf-da00-4bd0-a6f0-78ba5b84330e") \ No newline at end of file