Increase max_input_tokens to 5000 and update element_ids assignment i…

…n feedback model conversion
ls1intum · Dec 3, 2024 · 87a66a7 · 87a66a7
1 parent f2604c9
commit 87a66a7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/modeling/module_modeling_llm/module_modeling_llm/config.py b/modules/modeling/module_modeling_llm/module_modeling_llm/config.py
@@ -43,7 +43,7 @@ class GenerateSuggestionsPrompt(BaseModel):
 
 class BasicApproachConfig(BaseModel):
     """This approach uses a LLM with a single prompt to generate feedback in a single step."""
-    max_input_tokens: int = Field(default=3000, description="Maximum number of tokens in the input prompt.")
+    max_input_tokens: int = Field(default=5000, description="Maximum number of tokens in the input prompt.")
     model: ModelConfigType = Field(default=DefaultModelConfig())  # type: ignore
     generate_suggestions_prompt: GenerateSuggestionsPrompt = Field(default=GenerateSuggestionsPrompt())
 

diff --git a/...odeling/module_modeling_llm/module_modeling_llm/utils/convert_to_athana_feedback_model.py b/...odeling/module_modeling_llm/module_modeling_llm/utils/convert_to_athana_feedback_model.py
@@ -44,7 +44,7 @@ def convert_to_athana_feedback_model(
             id=None,
             is_graded=False,
             reference=reference,
-            element_ids=[reference_id] if reference_id else []
+            element_ids=[reference] if reference else [] # Todo: Remove after adding migrations to athena
         ))
 
     return feedbacks