From b870a365b20ba4ebfedae67520edeaeb0829e5bc Mon Sep 17 00:00:00 2001 From: Armin Stanitzok Date: Tue, 1 Oct 2024 16:51:48 +0200 Subject: [PATCH] fix: spacing + color --- .../app/home/leaderboard/leaderboard.component.html | 4 ++-- .../src/app/home/leaderboard/leaderboard.stories.ts | 12 ++++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/webapp/src/app/home/leaderboard/leaderboard.component.html b/webapp/src/app/home/leaderboard/leaderboard.component.html index a0979695..20f41cff 100644 --- a/webapp/src/app/home/leaderboard/leaderboard.component.html +++ b/webapp/src/app/home/leaderboard/leaderboard.component.html @@ -24,12 +24,12 @@ {{ entry.score }} -
+
{{ entry.numberOfReviewedPRs }}
-
+
@if (entry.changesRequested && entry.changesRequested.length > 0) { diff --git a/webapp/src/app/home/leaderboard/leaderboard.stories.ts b/webapp/src/app/home/leaderboard/leaderboard.stories.ts index 9432bb67..529cc2b7 100644 --- a/webapp/src/app/home/leaderboard/leaderboard.stories.ts +++ b/webapp/src/app/home/leaderboard/leaderboard.stories.ts @@ -25,7 +25,8 @@ const leaderboardEntries: LeaderboardEntry[] = [ changesRequested: generateReviews(3, PullRequestReviewDTO.StateEnum.ChangesRequested), approvals: generateReviews(5, PullRequestReviewDTO.StateEnum.Approved), comments: generateReviews(1, PullRequestReviewDTO.StateEnum.Commented), - rank: 1 + rank: 1, + numberOfReviewedPRs: 10 }, { githubName: 'FelixTJDietrich', @@ -36,7 +37,8 @@ const leaderboardEntries: LeaderboardEntry[] = [ changesRequested: generateReviews(1, PullRequestReviewDTO.StateEnum.ChangesRequested), approvals: generateReviews(1, PullRequestReviewDTO.StateEnum.Approved), comments: generateReviews(14, PullRequestReviewDTO.StateEnum.Commented), - rank: 2 + rank: 2, + numberOfReviewedPRs: 16 }, { githubName: 'krusche', @@ -47,7 +49,8 @@ const leaderboardEntries: LeaderboardEntry[] = [ changesRequested: [], approvals: generateReviews(3, PullRequestReviewDTO.StateEnum.Approved), comments: generateReviews(1, PullRequestReviewDTO.StateEnum.Commented), - rank: 3 + rank: 3, + numberOfReviewedPRs: 3 }, { githubName: 'shadcn', @@ -58,7 +61,8 @@ const leaderboardEntries: LeaderboardEntry[] = [ changesRequested: [], approvals: [], comments: generateReviews(1, PullRequestReviewDTO.StateEnum.Commented), - rank: 4 + rank: 4, + numberOfReviewedPRs: 1 } ];