From de37865917f7b3390c98d591d9a4299848e3bec9 Mon Sep 17 00:00:00 2001 From: Florian Ehrenstorfer Date: Fri, 20 Sep 2024 12:11:45 +0200 Subject: [PATCH] #82: remove PRNumber, add custom card colors --- .../www1/hephaestus/codereview/pullrequest/PullRequest.java | 3 --- .../codereview/pullrequest/PullRequestConverter.java | 1 - .../src/app/ui/app-issue-card/app-issue-card.component.html | 4 ++-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java b/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java index cdc0b67f..4e0f4dde 100644 --- a/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java +++ b/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequest.java @@ -33,9 +33,6 @@ public class PullRequest extends BaseGitServiceEntity { @NonNull private String url; - @NonNull - private int prNumber; - /** * State of the PullRequest. * Does not include the state of the merge. diff --git a/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java b/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java index faac7961..855152d1 100644 --- a/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java +++ b/server/application-server/src/main/java/de/tum/in/www1/hephaestus/codereview/pullrequest/PullRequestConverter.java @@ -28,7 +28,6 @@ public PullRequest convert(@NonNull GHPullRequest source) { pullRequest.setTitle(source.getTitle()); pullRequest.setUrl(source.getHtmlUrl().toString()); pullRequest.setState(state); - pullRequest.setPrNumber(source.getNumber()); pullRequest.setPullRequestLabels(convertLabels(source.getLabels())); try { pullRequest.setAdditions(source.getAdditions()); diff --git a/webapp/src/app/ui/app-issue-card/app-issue-card.component.html b/webapp/src/app/ui/app-issue-card/app-issue-card.component.html index 63a315ad..931bbaa2 100644 --- a/webapp/src/app/ui/app-issue-card/app-issue-card.component.html +++ b/webapp/src/app/ui/app-issue-card/app-issue-card.component.html @@ -1,7 +1,7 @@ -
+
- {{ pullRequest().repository.name }} #{{ pullRequest().number }} on {{ pullRequest().createdAt }} + {{ pullRequest().repository?.name }} #{{ pullRequest().number }} on {{ pullRequest().createdAt }} +{{ pullRequest().additions }}