-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM
: Add Langchain LLM wrapper classes
#57
Conversation
# Conflicts: # app/llm/basic_request_handler.py # app/llm/request_handler_interface.py # requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seen in action. Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have one minor suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm
Motivation
Langchain uses its own wrapper classes for LLM handling. Since we also use our own subsystem for handling LLMs we need to provide a wrapper for the wrapper.
Description
I added wrappers for all 3 currently supported LLM types (completion, chat, embedding) using the Langchain base classes as reference.