Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached files and linked lecture attachments open with authorization error in browser #117

Open
julian-wls opened this issue Nov 19, 2024 · 0 comments · May be fixed by #239
Open

Attached files and linked lecture attachments open with authorization error in browser #117

julian-wls opened this issue Nov 19, 2024 · 0 comments · May be fixed by #239
Assignees
Labels
bug Something isn't working

Comments

@julian-wls
Copy link
Contributor

julian-wls commented Nov 19, 2024

Description

As mentioned in #109, it is currently not possible to open resources like PDFs, etc, that were sent into the chat. #109 fixed the rendering of the links but did not fix the authorization issue.
When clicking on them, the user gets redirected to the browser, facing an authorization error instead of the requested resource.

Next steps

As a short-term solution, catch the link and open it manually, adding a cookie header, including the authorization token, would be a solid solution (see PostArtemisMarkdownTransformer and MarkdownText).
As a long-term solution, it would be good to have the files opened inside the app leading to a better usability:

  • Open lecture content in the lecture unit it belongs to
  • Open other files that were sent into the chat in a web view, maybe as modal bottom sheet.
@julian-wls julian-wls added bug Something isn't working blocked This issue is blocked by another issue. Please mention the blocking issue labels Nov 19, 2024
@julian-wls julian-wls self-assigned this Dec 6, 2024
@julian-wls julian-wls removed the blocked This issue is blocked by another issue. Please mention the blocking issue label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant