Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Only show resolve post if actionable #252

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Bugfix: Only show resolve post if actionable #252

wants to merge 8 commits into from

Conversation

FelberMartin
Copy link
Collaborator

Problem Description

The "Resolves Post" action did wrongly show up for when selecting a users own answer post, even when the user has no tutor rights and he is not the thread base post author.

This closes #240.

Changes

  • Fixed the bug
    • Changed IAnswerPost to include the parentAuthorId
    • Adapted inheriting classes
  • Changed ThreadUI to make use of IStandalonePost instead of PostPojo for easier testing
  • Created tests
  • Restructured test file

Steps for testing

Prerequisites: user without tutor rights

  • Go to a other user's post
  • Write a new answer to this post
  • Long press on your answer
  • The "Resolves Post" action does not show anymore

@FelberMartin FelberMartin self-assigned this Dec 21, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Dec 21, 2024
@FelberMartin FelberMartin requested a review from eylulnc December 21, 2024 11:53
eylulnc
eylulnc approved these changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@eylulnc eylulnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
Also implementation too, I have check it for both student and instructor.
Resolve not visible for students ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eylulnc eylulnc eylulnc approved these changes

@julian-wls julian-wls Awaiting requested review from julian-wls

Assignees

@FelberMartin FelberMartin

Labels
ready for review This PR can be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve post action shows for other people posts
2 participants
@FelberMartin @eylulnc