Improvement: Small adjustment to Code of Conduct sheet
#254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-wls
approved these changes
Jan 3, 2025
FelberMartin
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Changed the Code-of-Conduct bottom sheet from a half-screen modal to a full-screen display. The partial expansion previously blocked scrollable content, so adopting a full‐screen approach ensures all information is accessible in one click.
Note: This is a relatively small PR aimed to aligning the behavior with iOS and improving usability.
Changes
• Updated the Code-of-Conduct bottom sheet to always open as a full-screen modal on Android.
• Added slight padding for improved layout consistency, particularly for first-time acceptance of the Code of Conduct.
Steps for testing
• Confirm that the modal now matches iOS behavior, opening as a full-screen modal.
• Verify that there is a small but noticeable gap (padding) between the text and header menu for better visual alignment.
Screenshots