Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Smarty 5 #940

Open
s-hamann opened this issue Jul 10, 2024 · 2 comments
Open

Compatibility with Smarty 5 #940

s-hamann opened this issue Jul 10, 2024 · 2 comments
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@s-hamann
Copy link

It seems that as of version 5, Smarty uses a namespace, which is incompatible with how Self Service Password currently uses Smarty.
Trying to access Self Service Password with Smarty 5.3.1 (probably any 5.x version) results in an HTTP status code 500 and the following error logged:

PHP Fatal error:  Uncaught Error: Class "Smarty" not found in /var/www/ssp/htdocs/index.php:213

I fixed this locally by either adding use \Smarty\Smarty; to index.php or instantiating $smarty as new \Smarty\Smarty();. I can't tell if this breaks compatibility with Smarty versions 3 and 4, though.

@coudot coudot added the dependencies Pull requests that update a dependency file label Jul 10, 2024
@coudot
Copy link
Member

coudot commented Jul 10, 2024

Smarty 5 seems very young for the moment, we focus our efforts to Smarty 4 by now.

@coudot coudot added this to the Backlog milestone Jul 10, 2024
@s-hamann
Copy link
Author

In that case, I suggest updating the Prerequisite section in the README.md to reflect that users should not currently try running with Smarty >= 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants