Skip to content

Commit

Permalink
unconditially add suppressing flag
Browse files Browse the repository at this point in the history
  • Loading branch information
Vighnesh-V committed Oct 11, 2024
1 parent a7324ce commit 5d74685
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ else()
list(APPEND LUAU_OPTIONS -Wimplicit-fallthrough)
list(APPEND LUAU_OPTIONS -Wsign-compare) # This looks to be included in -Wall for GCC but not clang
list(APPEND LUAU_OPTIONS -Wno-maybe-uninitialized)

endif()

if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
Expand All @@ -124,8 +125,9 @@ endif()
if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# Some gcc versions treat var in `if (type var = val)` as unused
# Some gcc versions treat variables used in constexpr if blocks as unused
# list(APPEND LUAU_OPTIONS -Wno-unused)
list(APPEND LUAU_OPTIONS -Wno-unused)
# GCC has some bugs where we optional<string> is treated as uninitialized if it is on a structg

endif()

# Enabled in CI; we should be warning free on our main compiler versions but don't guarantee being warning free everywhere
Expand Down

0 comments on commit 5d74685

Please sign in to comment.