From bac85116f641de2ebac101fa30b95600b66705e6 Mon Sep 17 00:00:00 2001 From: vegorov-rbx <75688451+vegorov-rbx@users.noreply.github.com> Date: Mon, 25 Mar 2024 09:08:15 -0700 Subject: [PATCH] Fix CMake configuration error when CLI targets are not included (#1213) Doesn't really make sense to configure sources list based on target presence. Should fix https://github.com/luau-lang/luau/issues/1208 --- Sources.cmake | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/Sources.cmake b/Sources.cmake index 1ae40f3d3..a1711fe0e 100644 --- a/Sources.cmake +++ b/Sources.cmake @@ -356,19 +356,13 @@ target_sources(isocline PRIVATE extern/isocline/src/isocline.c ) - -if (TARGET Luau.Repl.CLI OR TARGET Luau.Analyze.CLI OR - TARGET Luau.Ast.CLI OR TARGET Luau.CLI.Test OR - TARGET Luau.Reduce.CLI OR TARGET Luau.Compile.CLI OR - TARGET Luau.Bytecode.CLI) - # Common sources shared between all CLI apps. - target_sources(Luau.CLI.lib PRIVATE - CLI/FileUtils.cpp - CLI/Flags.cpp - CLI/Flags.h - CLI/FileUtils.h - ) -endif() +# Common sources shared between all CLI apps +target_sources(Luau.CLI.lib PRIVATE + CLI/FileUtils.cpp + CLI/Flags.cpp + CLI/Flags.h + CLI/FileUtils.h +) if(TARGET Luau.Repl.CLI) # Luau.Repl.CLI Sources