nit - remove shared code allocator test section that tests self move

luau-lang · Oct 11, 2024 · f52fe9f · f52fe9f
1 parent a02bee5
commit f52fe9f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/tests/SharedCodeAllocator.test.cpp b/tests/SharedCodeAllocator.test.cpp
@@ -176,15 +176,7 @@ TEST_CASE("NativeModuleRefRefcounting")
     REQUIRE(modRefB->getRefcount() == 1);
 
     // NativeModuleRef self move assignment:
-    {
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wself-move"
-        NativeModuleRef modRef1{modRefA};
-        modRef1 = std::move(modRef1);
-        REQUIRE(modRef1.get() == modRefA.get());
-        REQUIRE(modRefA->getRefcount() == 2);
-#pragma GCC diagnostic pop
-    }
+    // deleted because of unecessary warnings
 
     REQUIRE(modRefA->getRefcount() == 1);
     REQUIRE(modRefB->getRefcount() == 1);

diff --git a/tests/TypeVar.test.cpp b/tests/TypeVar.test.cpp
@@ -465,8 +465,6 @@ TEST_CASE("proof_that_isBoolean_uses_all_of")
 
 TEST_CASE("content_reassignment")
 {
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wgimaybe-uninitialized"
     Type myAny{AnyType{}, /*presistent*/ true};
     myAny.documentationSymbol = "@global/any";
 
@@ -479,7 +477,6 @@ TEST_CASE("content_reassignment")
     CHECK(!futureAny->persistent);
     CHECK(futureAny->documentationSymbol == "@global/any");
     CHECK(futureAny->owningArena == &arena);
-#pragma GCC diagnostic pop
 }
 
 TEST_SUITE_END();