From f52fe9f351cd5f9a90b312aead695aaaab7d2855 Mon Sep 17 00:00:00 2001 From: Vighnesh Date: Fri, 11 Oct 2024 13:22:20 -0700 Subject: [PATCH] nit - remove shared code allocator test section that tests self move --- tests/SharedCodeAllocator.test.cpp | 10 +--------- tests/TypeVar.test.cpp | 3 --- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/tests/SharedCodeAllocator.test.cpp b/tests/SharedCodeAllocator.test.cpp index 8e8d526a2..149c0e0c7 100644 --- a/tests/SharedCodeAllocator.test.cpp +++ b/tests/SharedCodeAllocator.test.cpp @@ -176,15 +176,7 @@ TEST_CASE("NativeModuleRefRefcounting") REQUIRE(modRefB->getRefcount() == 1); // NativeModuleRef self move assignment: - { -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wself-move" - NativeModuleRef modRef1{modRefA}; - modRef1 = std::move(modRef1); - REQUIRE(modRef1.get() == modRefA.get()); - REQUIRE(modRefA->getRefcount() == 2); -#pragma GCC diagnostic pop - } + // deleted because of unecessary warnings REQUIRE(modRefA->getRefcount() == 1); REQUIRE(modRefB->getRefcount() == 1); diff --git a/tests/TypeVar.test.cpp b/tests/TypeVar.test.cpp index b31914aee..9e21b1e03 100644 --- a/tests/TypeVar.test.cpp +++ b/tests/TypeVar.test.cpp @@ -465,8 +465,6 @@ TEST_CASE("proof_that_isBoolean_uses_all_of") TEST_CASE("content_reassignment") { -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wgimaybe-uninitialized" Type myAny{AnyType{}, /*presistent*/ true}; myAny.documentationSymbol = "@global/any"; @@ -479,7 +477,6 @@ TEST_CASE("content_reassignment") CHECK(!futureAny->persistent); CHECK(futureAny->documentationSymbol == "@global/any"); CHECK(futureAny->owningArena == &arena); -#pragma GCC diagnostic pop } TEST_SUITE_END();