Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NfcReactNativePackage Method does not override or implement a method from a supertype #15

Open
kzettlmeier opened this issue Oct 10, 2017 · 1 comment

Comments

@kzettlmeier
Copy link

Looks like there currently is an error during compile:

node_modules/nfc-react-native/android/src/main/java/es/tiarg/nfcreactnative/NfcReactNativePackage.java:33: error: method does not override or implement a method from a supertype
    @Override
    ^
1 error
:nfc-react-native:compileReleaseJavaWithJavac FAILED

From what I can tell there is a breaking change in react-native 0.47 where you need to remove the @OverRide statement at

    @Override
    public List<Class<? extends JavaScriptModule>> createJSModules() {
        return Collections.emptyList();
    }
@zxhycxq
Copy link

zxhycxq commented Oct 17, 2017

@kzettlmeier you can delete @Override.me too.hope to help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants