Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragging of sheet when dragging is started on top of button or other pressable item #153

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Fix dragging of sheet when dragging is started on top of button or other pressable item #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Sources/BottomSheet/BottomSheetView/BottomSheetView+HelperViews.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@
// Main content
self.mainContent
// Make the main content drag-able if content drag is enabled
.gesture(
// highPriorityGesture is required to make dragging the bottom sheet work even when user starts dragging on buttons or other pressable items

Check warning on line 184 in Sources/BottomSheet/BottomSheetView/BottomSheetView+HelperViews.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

Line Length Violation: Line should be 120 characters or less; currently it has 156 characters (line_length)
.highPriorityGesture(
self.configuration.isContentDragEnabled && self.configuration.isResizable ?
self.dragGesture(with: geometry) : nil
)
Expand Down Expand Up @@ -401,4 +402,4 @@
return 0
}
}
}

Check warning on line 405 in Sources/BottomSheet/BottomSheetView/BottomSheetView+HelperViews.swift

View workflow job for this annotation

GitHub Actions / SwiftLint 

File Length Violation: File should contain 400 lines or less: currently contains 405 (file_length)
Loading