Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Better OAuth errors #1210

Closed
pilcrowonpaper opened this issue Oct 19, 2023 · 1 comment
Closed

[Feature Request]: Better OAuth errors #1210

pilcrowonpaper opened this issue Oct 19, 2023 · 1 comment
Labels
feature request New feature requests

Comments

@pilcrowonpaper
Copy link
Member

Description

The error response body for the token endpoint is standardized so it's likely that we can provide a more useful error when using validateOAuth2AuthorizationCode(). Something to keep in mind is that Github returns a 200 error status for invalid authorization code, and that seems to be technically allowed?

The authorization server responds with an HTTP 400 (Bad Request) status code (unless specified otherwise)
@pilcrowonpaper pilcrowonpaper added the feature request New feature requests label Oct 19, 2023
@pilcrowonpaper pilcrowonpaper linked a pull request Nov 16, 2023 that will close this issue
Lucia v3 #1258
Merged
6 tasks
@pilcrowonpaper
Copy link
Member Author

Closing this since we're replacing the OAuth integration with Arctic, which already has better errors

@pilcrowonpaper pilcrowonpaper closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2023
@pilcrowonpaper pilcrowonpaper removed a link to a pull request Jan 26, 2024
Lucia v3 #1258
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pilcrowonpaper