Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Nudge from Bottom / Right #24

Open
nikosdion opened this issue Feb 23, 2021 · 0 comments
Open

Implement Nudge from Bottom / Right #24

nikosdion opened this issue Feb 23, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@nikosdion
Copy link
Collaborator

The nudge values are currently only ever set from the Top or Left edge.

We could have a dropdown to select Top/Bottom and Left/Right, changing the nudge labels accordingly.

The implementation is fairly straightforward.

Nudge from Bottom can be converted to a nudge from top value by doing image height - text box height - nudge from bottom.

Nudge from Right can be converted to a nudge from left value by doing image width - text box width - nudge from right.

This way we can leave our implementations as they are, adding the minimal code required to convert the bottom/right nudge values into their equivalent top/left values.

@nikosdion nikosdion self-assigned this Feb 23, 2021
@nikosdion nikosdion added the enhancement New feature or request label Feb 23, 2021
@nikosdion nikosdion added this to the 2.0 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant