Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Names to_k, to_q, to_v, to_out cause issues #71

Open
JamesDeAntonis opened this issue Jun 4, 2021 · 0 comments
Open

Names to_k, to_q, to_v, to_out cause issues #71

JamesDeAntonis opened this issue Jun 4, 2021 · 0 comments

Comments

@JamesDeAntonis
Copy link

Hi Lucid,

Hope all is well. Is there any need to have the q, k, v, o be named to_k, to_q, to_v, to_out? This causes lots of incompatibility with huggingface, since they call them q, k, v, o. Any chance we could change this to the HF convention?

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesDeAntonis