Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ruleset/workspace name #25

Open
SrodriguezO opened this issue Aug 6, 2019 · 7 comments
Open

Inconsistent ruleset/workspace name #25

SrodriguezO opened this issue Aug 6, 2019 · 7 comments

Comments

@SrodriguezO
Copy link
Contributor

The ruleset is name rules_play_routes but its workspace and is named io_bazel_rules_play_routes.

We should rename the workspace to rules_play_routes.

@borkaehw
Copy link
Contributor

borkaehw commented Aug 6, 2019

I noticed that before, but it seems to be the convention of Bazel ruleset. rules_go and rules_docker do the same.

@JaredNeil
Copy link
Member

This page explains the standard naming conventions: https://docs.bazel.build/versions/master/skylark/deploying.html

@borkaehw
Copy link
Contributor

borkaehw commented Aug 7, 2019

If your rules belong to the bazelbuild organization, you must use rules_<lang> (e.g. rules_mockascript). Otherwise, you should name your repository <org>_rules_<lang> (e.g. build_stack_rules_proto).

Should it be lucidsoftware_rules_play_routes in our case?

@SrodriguezO
Copy link
Contributor Author

Should it be lucidsoftware_rules_play_routes in our case?

I'm fine with going with that for the workspace name. It still wouldn't match the git repo name though.

Trying to get these into bazelbuild might be a good option (along with rules_twirl).

@borkaehw
Copy link
Contributor

borkaehw commented Aug 7, 2019

As far as I can see, most of the rules that live in bazelbuild have prefix io_bazel_, same as what we currently have.

@SrodriguezO
Copy link
Contributor Author

Hmm I think you're right. It seems nobody's following the standard convention 🙃

@JaredNeil
Copy link
Member

Well it was just standardized 16 days ago in bazelbuild/bazel#8884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants