Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add middleware for viewing sent emails #3

Closed
paulcsmith opened this issue Apr 7, 2018 · 4 comments
Closed

Add middleware for viewing sent emails #3

paulcsmith opened this issue Apr 7, 2018 · 4 comments

Comments

@paulcsmith
Copy link
Member

No description provided.

@hfjallemark
Copy link

If this is about the DevAdapter I would propose a simpler solution (at least in the interim); just log the e-mail in the console.

I did this locally to see the e-mail contents:

def deliver_now(email : Carbon::Email)
  puts email.text_body
 @@delivered_emails << email
end

@paulcsmith
Copy link
Member Author

I like that idea as a nice interim solution! I'm thinking DevAdapter can accept an argument so that it doesn't print in test:

Carbon::DevAdapter.new(print_emails: Lucky::Env.development?)

I'll create an issue for this

@matthewmcgarvey
Copy link
Member

Looking at this issue, I assume by "middleware" you mean adding a way to provide http endpoints to view sent emails.

Since we recently created pulsar I'm thinking that we add events to the carbon library and then a new shard could be made with a dependency on carbon and lucky (because carbon does not depend on lucky right now and it probably shouldn't) and listens to those events and provides some nice pages.

@matthewmcgarvey
Copy link
Member

A general purpose admin/development tool is being made with a plan to integrate with carbon. In order to do that, we need to add pulsar and events. "middleware" is not needed at this point.

Replaced by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants