Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The layout filename should include the content type #77

Open
jwoertink opened this issue Oct 1, 2022 · 0 comments
Open

The layout filename should include the content type #77

jwoertink opened this issue Oct 1, 2022 · 0 comments

Comments

@jwoertink
Copy link
Member

carbon/src/carbon/email.cr

Line 60 in 61e75c5

ECR.embed "#{__DIR__}/templates/\{{ template_name.id }}/layout.ecr", layout_io

Related: #76

Instead of generating layout.ecr, it should look more like layout.html.ecr; however, if we change the naming, then this really become layout/your_layout_name.html.ecr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwoertink