Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed task uses log instead of puts #706

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkthorne
Copy link
Contributor

@jkthorne jkthorne commented Dec 8, 2021

This moves to use puts so you can suppress output if you want.

Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of being able to suppress the output, but if it's just Log, then you'd have to turn that off globally which might not be wanted. We could look at doing something like LuckyTask::Log.info, then you can tune it for tasks specifically... But really, I think maybe this should actually be output.puts and use the output property on LuckyTask

https://github.com/luckyframework/lucky_task/blob/da2bfd5d69c6aab7e5c4a1e998469645d4b31a63/src/lucky_task/task.cr#L6

Then maybe we add a habitat config for tasks that allow you to just turn off all output. What do you think about going with one of those approaches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants