Fix possible off by 1 error when reading strings

luizzeroxis · Aug 23, 2024 · 5298e42 · 5298e42
1 parent 6f470f8
commit 5298e42
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/UndertaleModLib/Util/BufferBinaryReader.cs b/UndertaleModLib/Util/BufferBinaryReader.cs
@@ -286,7 +286,7 @@ public string ReadGMString()
 
             if (length < 0)
                 throw new IOException("Invalid string length");
-            if (chunkBuffer.Position + length + 1 >= _length)
+            if (chunkBuffer.Position + length + 1 > _length) // "+ 1" because of the null terminator
                 throw new IOException("Reading out of chunk bounds");
 
             string res;

diff --git a/UndertaleModLib/Util/FileBinaryReader.cs b/UndertaleModLib/Util/FileBinaryReader.cs
@@ -214,7 +214,7 @@ public string ReadGMString()
 
             if (length < 0)
                 throw new IOException("Invalid string length");
-            if (Stream.Position + length + 1 >= _length)
+            if (Stream.Position + length + 1 > _length) // "+ 1" because of the null terminator
                 throw new IOException("Reading out of bounds");
 
             string res;