Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate type is required when querying for events #24

Open
lukaszb opened this issue Mar 25, 2017 · 0 comments
Open

Aggregate type is required when querying for events #24

lukaszb opened this issue Mar 25, 2017 · 0 comments
Labels

Comments

@lukaszb
Copy link
Owner

lukaszb commented Mar 25, 2017

https://github.com/lukaszb/cq/blob/devel/cq/storages.py#L66

Signature of Storage.get_events should be extended with required aggregate_type param. Now, if aggregate id clashes with another aggregate type, an error would be thrown (there would be no mutator for found aggregate).

@lukaszb lukaszb added the bug label Mar 25, 2017
lukaszb added a commit that referenced this issue Mar 26, 2017
lukaszb added a commit that referenced this issue Apr 28, 2017
* added pytest-watch to devel reqs

* travis should test against python 3.6

* updated tox config

* started fixing #24

* Fixed django implementation of get_events

* fixed sqlalchemy storage get_events method

* added test

* added tox to devel reqs

* updated travis and tox

* added migration

* Updated tox config

* start using aggregate type everywhere

* allow to pass args to pytest

* fixed sqlalchemy

* fixed local storage

* added changelog
lukaszb added a commit that referenced this issue May 4, 2017
* added python 3.6 to tox

* Set dev version

* Ignore dist by git

* Merge from master

* show info on django_makemigrations when running make

* added index to ts field for django storage

* Respect aggregate type when querying events (#25)

* added pytest-watch to devel reqs

* travis should test against python 3.6

* updated tox config

* started fixing #24

* Fixed django implementation of get_events

* fixed sqlalchemy storage get_events method

* added test

* added tox to devel reqs

* updated travis and tox

* added migration

* Updated tox config

* start using aggregate type everywhere

* allow to pass args to pytest

* fixed sqlalchemy

* fixed local storage

* added changelog

* Renamed publish to handle_event (#27)

* Renamed publish to handle_event

* Updated changelog

* moved test fixture to conftest

* aggregate version should be 1 after first mutation

* use CQ_ instead of SES_

* use own import_string

* added test for aggregate version bump

* rollback imports at __init__

* added ability to upcast events - fixes #26 (#30)

* added ability to upcast events - fixes #26

* updated changelog

* refactor

* add revision when storing an event

* updated "make django_makemigrations"

* storages should include revision info

* added test

* typo

* Declarative app repos (#31)

* allow to define repos for app declaratively

* updated changelog

* declare repo

* Iter all events (#34)

* implemented LocalStorage.iter_all_events

* updated changelog

* implemented iter_all_events for Django storage

* implemented iter_all_events for sqlalchemy storage

* allow to replay events (fixes #22)

* started working on events replays

* move replay events to storage

* removed unused function

* better info on exception

* removed unused import

* fixed handler for Django test app

* removed print

* updated changelog

* fixed issue of registering multiple mutators under base Aggregate class (#36)

* upcasters should be defined at aggregate class (#37)

* freeze v0.9

* upcast events when rehydrating an aggregate (#38)

* replay_events should respect upcasters param (#39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant