Add support/tests for Conan 2 and Python 3.12 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we don't get surprise file reformatting.
The `#egg=` format is deprecated and will be removed in pip 25. It also turns out that the latest `pylake` git clone goes over the Windows file path limit when checked out as part of `pip install`. `git config --system core.longpaths true` resolves it.
hellozee
approved these changes
May 3, 2024
Some projects may end up calling `find_package(embedded_python[-core])` multiple times in their CMake code. By extension `find_package(Python)` gets called many times and it's pretty slow because it needs to run some Python to get all the details about the interpreter. We can make sure that this only runs once. Conan ensures that only one version of `embedded_python-core` is always included in the project so the first info is save to cache and will not change.
It stopped doing anything in v1.8.0. Time to remove it.
v1.6.0 introduced `embedded_python-core` and left the `version` option in the non-core package for backward compatibility. At this point, it's too confusing to have both, so let's drop it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Conan 1 and 2 are tested in the CI matrix. We'll support both for a while. Python 3.12 is in, Python 3.10 and older are out. This was a good opportunity to drop the old versions, mainly to avoid having to support both
opensslv1 and v3 dependencies.The PR diff line count is inflated because of machine-generated
envfile changes. The actual diff is ~100 lines. Review per commit for the best experience. Note that the 4 commits are simply repo maintenance.