Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding guestbook-datomic PR #6

Merged
merged 5 commits into from
Jun 12, 2018
Merged

Conversation

Folcon
Copy link
Contributor

@Folcon Folcon commented Jun 11, 2018

PR associated with #5.

@Folcon
Copy link
Contributor Author

Folcon commented Jun 11, 2018

Not sure if you wanted to make changes to it =)...

@yogthos
Copy link
Member

yogthos commented Jun 12, 2018

Looks good, I'll take a look at adding a note in the docs as well. Might be an idea to add a datomic section here. The sections displayed on the site are managed via config here.

@yogthos yogthos merged commit 7665e03 into luminus-framework:master Jun 12, 2018
@Folcon
Copy link
Contributor Author

Folcon commented Jun 12, 2018

Hmm, what types of things would you want me to document? A high level idea is sufficient, I can start to organise something and see what I come up with =)...

@yogthos
Copy link
Member

yogthos commented Jun 12, 2018

I was thinking it might be good to give a brief overview of getting up and running with Datomic. Something similar to the existing material in the "Database Access" section, and we could link the sample project from there. If you can think of any gotchas to mention, stuff like using mem db for dev, etc. would be good to add.

@Folcon
Copy link
Contributor Author

Folcon commented Jun 15, 2018

Ok, so sections on:

  1. on development with datomic
  2. datomic in production?
  3. I'm working on getting drawbridge working with heroku, something about this?

For 2., I'm not sure how worthwhile it is documenting (I really seem to have gone off the beaten path with my approach, but if you keep banging your head against the wall, sooner or later it gives
😄...), but in my case datomic in production runs in heroku. The transactor has no access to the outside world (which I think makes it reasonably secure), as it doesn't bind to the external port and I bundle my jar file alongside the transactor so it can talk to it. The data is stored on heroku postgres store (which took some time to wrangle).

I'm not sure it's super robust, but for anyone wanting to run a datomic instance in the heroku ecosystem at a reasonable starting price point I've found it works great. I'm pretty sure that I can then work out how to migrate up if I need it, but for the moment, its sufficient. Do you want me to do a section on it?

@yogthos
Copy link
Member

yogthos commented Jun 15, 2018

Yeah these sections sound pretty reasonable to help people get started. I'd focus on documenting things specific to using Datomic from Luminus, and link to the official docs for more details on Datomic itself. Giving an example of the Heroku setup would be great as well. I agree that it's generally a good idea not to expose the DB to the outside world. :)

@Folcon
Copy link
Contributor Author

Folcon commented Jun 24, 2018

@yogthos I've got something drafted for 2), shall I pop it up somewhere? Maybe a PR on the docs?.

For 1) I'm still working out what to write regarding it, and for 3) I've got something working, but there's still an open issue I'm trying to get sorted out. I can document what I have working already, or hopefully I'll hear something soon and can get it fixed.

@yogthos
Copy link
Member

yogthos commented Jun 24, 2018

Yeah, a PR for the docs site would be ideal, and probably wouldn't hurt to add what you've got already. Can always do another PR later once the issue resolves.

@Folcon
Copy link
Contributor Author

Folcon commented Jun 24, 2018

Here's the first draft.

@yogthos
Copy link
Member

yogthos commented Jun 25, 2018

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants