fix(outputHandler_json): for pending tests and json encoding #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
requested changes
Nov 29, 2024
YaroSpace
force-pushed
the
master
branch
3 times, most recently
from
293770f to
fea7d53
Compare
alerque
requested changes
Nov 29, 2024
YaroSpace
force-pushed
the
master
branch
2 times, most recently
from
5d346ba to
083eae0
Compare
alerque
reviewed
Nov 29, 2024
Comment on lines
+36
to
+37
| io_write(err_msg) | ||
| error(err_msg) |
There was a problem hiding this comment.
Why write and error the same message? Is this what the other instances in the code base of manually writing to stderr and then exiting are working around?
Suggested change
| io_write(err_msg) | |
| error(err_msg) | |
| error(err_msg) |
There was a problem hiding this comment.
In my undertading, writing to stdout here is for the cases when json output is redirected to a file, so that the error goes to the file too. I assumed someone maybe relying on that, so left this line just in case, but with a better error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #729: pending tests without function argument have an attribute of
default_fn: <function>, which cannot be encoded into json.Improved json output formatter to handle pending tests and provide better error reporting if custom non-string attributes cannot be encoded into json.