Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP >= 7.2.5 #230

Closed
hristokpopov opened this issue Sep 29, 2023 · 2 comments
Closed

Support PHP >= 7.2.5 #230

hristokpopov opened this issue Sep 29, 2023 · 2 comments

Comments

@hristokpopov
Copy link

Branch 3.x works fine with the following PHP versions >= 7.2.5

I have done some testing with the following fork:
https://github.com/hristokpopov/LocaleBundle/tree/php7

phpunit tests seem to pass as well. A few warnings are generated, but they are not related to the php version.

PHP >= 7.2.5 matches the version needed for Symfony 5.4:
https://symfony.com/releases/5.4

Would it be possible to change the PHP requirement in composer.json to:
"php": ">=7.2.5"

@goetas
Copy link
Collaborator

goetas commented Sep 29, 2023

if you can create a merge request and make the CI green, I do not see issues with it

@hristokpopov
Copy link
Author

The PHP requirement was changed to >= 7.2.5:
#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants