Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change printed representation of hex digests #416

Open
wwared opened this issue Jan 23, 2025 · 0 comments
Open

Change printed representation of hex digests #416

wwared opened this issue Jan 23, 2025 · 0 comments

Comments

@wwared
Copy link
Contributor

wwared commented Jan 23, 2025

Currently, we're directly printing the 124-ish bit hex representation for BigNums and commitments. We want to change it to print a 128-bit representation, where each 4-byte chunk is aligned at the u32 boundary to BabyBear field elements.

  • Rename BigInt to FieldBuffer (or similar)
  • Switch the reading/printing to use a flat 8xu32 array, validating that there is no overflow in any field element when reading
  • Update hashes in tests and user-manual documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant