Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACL should apply allow first when default action is allow #1833

Open
stgraber opened this issue Mar 23, 2025 · 0 comments
Open

ACL should apply allow first when default action is allow #1833

stgraber opened this issue Mar 23, 2025 · 0 comments
Labels
Documentation Documentation needs updating Easy Good for new contributors
Milestone

Comments

@stgraber
Copy link
Member

stgraber commented Mar 23, 2025

Currently when applying ACLs, Incus will first apply all drop/reject, then apply the allow rules and finally the policy which defaults to reject.

That's a good order for this particular case as it allows having wide allow rules with narrow reject/drop rules to block a subset of what's allowed, then the policy rejects the rest.

But this apply order isn't a good fit when the default policy is allow as in that situation one would likely have pretty broad reject/drop rules and so want the allow rules applied first to allow a subset of what would otherwise be denied by broader reject/drop rules.

So we should change our default apply order to match, basically reversing the order if the default action is allow.

@stgraber stgraber added Documentation Documentation needs updating Easy Good for new contributors labels Mar 23, 2025
@stgraber stgraber added this to the soon milestone Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation needs updating Easy Good for new contributors
Development

No branches or pull requests

1 participant