Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some arguments from load_model to transcribe(),... #1042

Open
Barabazs opened this issue Feb 12, 2025 · 0 comments
Open

Move some arguments from load_model to transcribe(),... #1042

Barabazs opened this issue Feb 12, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Barabazs
Copy link
Collaborator

i think 3 often used args task, language, initial_prompt should be moved from load_model() to transcribe() for compatibility with original whisper

related: #191 #259

Originally posted by @phineas-pta in #241

I've also noticed many users wanting to pass/change specific parameters after loading the model.
It might be interesting to see if this is indeed needed and produces a better user experience.

fwiw, the current use of dicts for settings makes it hard to track which option is appropriate in any of the methods. Migrating from dicts to Pydantic models might be good idea.

@Barabazs Barabazs added the enhancement New feature or request label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant