From de037343246f4a7a6b66b647b5e9e23da0905052 Mon Sep 17 00:00:00 2001 From: Greg Russell Date: Tue, 12 Dec 2017 17:54:10 -0500 Subject: [PATCH] add TODO and better comment --- bqext/dataset_integration_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/bqext/dataset_integration_test.go b/bqext/dataset_integration_test.go index b60c1f5..9025c73 100644 --- a/bqext/dataset_integration_test.go +++ b/bqext/dataset_integration_test.go @@ -21,6 +21,8 @@ package bqext_test // on the state of our bigquery tables, so they may start failing // if the tables are changed. +// TODO (issue #8) tests that use bq tables should create them from scratch. + import ( "encoding/json" "fmt" @@ -80,10 +82,12 @@ func TestGetTableStats(t *testing.T) { } // PartitionInfo provides basic information about a partition. +// Note that a similar struct is defined in dataset.go, but this +// one is used for testing the QueryAndParse method. type PartitionInfo struct { - PartitionID string `qfield:"partition_id"` - // CreationTime time.Time `qfield:"created"` - // LastModified time.Time `qfield:"last_modified"` + PartitionID string + CreationTime time.Time + LastModified time.Time } func TestQueryAndParse(t *testing.T) {