Remove workerjs #32
Open
Remove workerjs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertodauria
approved these changes
Jan 31, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
|
@RA80533 I've updated this branch by merging from main, but it seems I don't have permission to push the updated minified files. Would you please run |
robertodauria
requested changes
Feb 14, 2022
There was a problem hiding this comment.
While testing this in a separate branch (so I could fix the merge conflicts) with nodejs v14.x I have noticed that it does not seem to fully work:
global.Worker = require('worker_threads');should beglobal.Worker = require('worker_threads').Worker;or I get an error about Worker not being a constructor- even after this change, there is something strange with the message passing between the worker and the main thread -- it seems the server measurements during the download are never stored:
roberto@asimov:~/git/ndt7-js$ node examples/node-client.js
Testing to: {
machine: 'mlab3-mil06.mlab-oti.measurement-lab.org',
locations: { city: 'Milan', country: 'IT' }
}
/home/roberto/git/ndt7-js/examples/node-client.js:23
const serverBw = data.LastServerMeasurement.BBRInfo.BW * 8 / 1000000;
^
TypeError: Cannot read property 'BBRInfo' of undefined
at Object.downloadComplete [as complete] (/home/roberto/git/ndt7-js/examples/node-client.js:23:53)
at Worker.worker.resolve (/home/roberto/git/ndt7-js/src/ndt7.js:153:23)
at Timeout._onTimeout (/home/roberto/git/ndt7-js/src/ndt7.js:168:53)
at listOnTimeout (internal/timers.js:557:17)
at processTimers (internal/timers.js:500:7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
This change is