Skip to content

Commit 2e0e957

Browse files
fix: Strickmode Error
1 parent ca4fd0b commit 2e0e957

File tree

2 files changed

+12
-16
lines changed

2 files changed

+12
-16
lines changed

android-core/src/main/java/com/mparticle/internal/DeviceAttributes.java

+8-9
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package com.mparticle.internal;
22

3+
import android.app.Application;
34
import android.content.Context;
45
import android.content.SharedPreferences;
56
import android.content.pm.ApplicationInfo;
@@ -8,7 +9,6 @@
89
import android.os.Build;
910
import android.telephony.TelephonyManager;
1011
import android.util.DisplayMetrics;
11-
import android.view.WindowManager;
1212

1313
import com.mparticle.MParticle;
1414
import com.mparticle.internal.Constants.MessageKey;
@@ -196,9 +196,9 @@ JSONObject getStaticDeviceInfo(Context appContext) {
196196
attributes.put(MessageKey.OS_VERSION_INT, Build.VERSION.SDK_INT);
197197
attributes.put(MessageKey.MODEL, android.os.Build.MODEL);
198198
attributes.put(MessageKey.RELEASE_VERSION, Build.VERSION.RELEASE);
199-
199+
Application application = (Application) appContext;
200200
// device ID
201-
addAndroidId(attributes, appContext);
201+
addAndroidId(attributes, application);
202202

203203
attributes.put(MessageKey.DEVICE_BLUETOOTH_ENABLED, MPUtility.isBluetoothEnabled(appContext));
204204
attributes.put(MessageKey.DEVICE_BLUETOOTH_VERSION, MPUtility.getBluetoothVersion(appContext));
@@ -210,12 +210,11 @@ JSONObject getStaticDeviceInfo(Context appContext) {
210210
attributes.put(MessageKey.DEVICE_ROOTED, rootedObject);
211211

212212
// screen height/width
213-
WindowManager windowManager = (WindowManager) appContext.getSystemService(Context.WINDOW_SERVICE);
214-
DisplayMetrics metrics = new DisplayMetrics();
215-
windowManager.getDefaultDisplay().getMetrics(metrics);
216-
attributes.put(MessageKey.SCREEN_HEIGHT, metrics.heightPixels);
217-
attributes.put(MessageKey.SCREEN_WIDTH, metrics.widthPixels);
218-
attributes.put(MessageKey.SCREEN_DPI, metrics.densityDpi);
213+
DisplayMetrics displayMetrics = appContext.getResources().getDisplayMetrics();
214+
215+
attributes.put(MessageKey.SCREEN_HEIGHT, displayMetrics.heightPixels);
216+
attributes.put(MessageKey.SCREEN_WIDTH, displayMetrics.widthPixels);
217+
attributes.put(MessageKey.SCREEN_DPI, displayMetrics.densityDpi);
219218

220219
// locales
221220
Locale locale = Locale.getDefault();

android-core/src/main/java/com/mparticle/internal/MPUtility.java

+4-7
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@
2020
import android.os.StatFs;
2121
import android.provider.Settings;
2222
import android.telephony.TelephonyManager;
23-
import android.view.Display;
24-
import android.view.WindowManager;
23+
import android.util.DisplayMetrics;
2524

2625
import androidx.annotation.Nullable;
2726
import androidx.annotation.WorkerThread;
@@ -369,14 +368,12 @@ public static String getTimeZone() {
369368
}
370369

371370
public static int getOrientation(Context context) {
372-
WindowManager windowManager = (WindowManager) context
373-
.getSystemService(Context.WINDOW_SERVICE);
374-
Display getOrient = windowManager.getDefaultDisplay();
371+
DisplayMetrics displayMetrics = context.getResources().getDisplayMetrics();
375372
int orientation = Configuration.ORIENTATION_UNDEFINED;
376-
if (getOrient.getWidth() == getOrient.getHeight()) {
373+
if (displayMetrics.widthPixels == displayMetrics.heightPixels) {
377374
orientation = Configuration.ORIENTATION_SQUARE;
378375
} else {
379-
if (getOrient.getWidth() < getOrient.getHeight()) {
376+
if (displayMetrics.widthPixels < displayMetrics.heightPixels) {
380377
orientation = Configuration.ORIENTATION_PORTRAIT;
381378
} else {
382379
orientation = Configuration.ORIENTATION_LANDSCAPE;

0 commit comments

Comments
 (0)