Address PR Comments

mParticle · Jan 17, 2025 · f8c9e14 · f8c9e14
1 parent e04dbe3
commit f8c9e14
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/sdkRuntimeModels.ts b/src/sdkRuntimeModels.ts
@@ -156,7 +156,7 @@ export interface SDKProduct {
     Position?: number;
     CouponCode?: string;
     TotalAmount?: number;
-    Attributes?: { [key: string]: string };
+    Attributes?: Record<string, unknown> | undefined;
 }
 
 export interface MParticleWebSDK {

diff --git a/test/src/tests-identity.ts b/test/src/tests-identity.ts
@@ -4799,11 +4799,11 @@ describe('identity', function() {
             waitForCondition(hasIdentifyReturned)
             .then(() => {
 
-            const product: Product = mParticle.eCommerce.createProduct(
+            const product: SDKProduct = mParticle.eCommerce.createProduct(
                 'iPhone',
                 '12345',
                 400
-            ) as Product;
+            );
             mParticle
                 .getInstance()
                 .Identity.getCurrentUser()
@@ -4831,11 +4831,11 @@ describe('identity', function() {
             waitForCondition(hasIdentifyReturned)
             .then(() => {
 
-            const product: Product = mParticle.eCommerce.createProduct(
+            const product: SDKProduct = mParticle.eCommerce.createProduct(
                 'iPhone',
                 '12345',
                 400
-            ) as Product;
+            );
 
             mParticle
                 .getInstance()