Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider whether should we remove stm32f7xx_it.h #24

Open
takasehideki opened this issue Jan 3, 2021 · 2 comments
Open

Consider whether should we remove stm32f7xx_it.h #24

takasehideki opened this issue Jan 3, 2021 · 2 comments

Comments

@takasehideki
Copy link
Member

sample1.cfg でincludeされている stm32f7xx_it.h は不要ではないか？
他にも application/ 以下で不要なファイルがありそう．混乱を招くもとになりうるので，削除を検討する．

https://github.com/tlk-emb/asp-stm32f767/blob/71a3c037284af45680d3351489db1cb2496083c5/workspace/comm_tests/ping/sample1.cfg#L14
@takasehideki
Copy link
Member Author

すみません勘違いでした．ETH_IRQHandlerの定義に必要ですね．

@takasehideki
Copy link
Member Author

けっきょくHAL_ETH_IRQ_Handlerを呼び出しているだけなので，やはり不要なのでは？？

https://github.com/tlk-emb/asp-stm32f767/blob/71a3c037284af45680d3351489db1cb2496083c5/application/src/stm32f7xx_it.c#L177-L189

@takasehideki takasehideki reopened this Jan 3, 2021
@takasehideki takasehideki mentioned this issue Jul 2, 2021
Closed
@takasehideki takasehideki changed the title stm32f7xx_it.h の除去の検討 Consider whether should we remove stm32f7xx_it.h Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@takasehideki