Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing keys #182

Open
pimterry opened this issue Apr 15, 2018 · 9 comments
Open

Editing keys #182

pimterry opened this issue Apr 15, 2018 · 9 comments

Comments

@pimterry
Copy link

Is there any way to edit a key? It'd be really useful to be able to rename properties.

I see this was mentioned in #91, but it looked like it got closed without this being added, as far as I can tell.

@mac-s-g
Copy link
Owner

mac-s-g commented Apr 16, 2018

editing a key was not implemented. I ran into UX issues when playing with an implementation. How would you expect it to work? Would you like to see an extra button that pops open a modal?

@pimterry
Copy link
Author

@mac-s-g makes sense! I'm imagining something pretty close to the current implementation I think:

  • An extra button when mousing over keys, i.e. there should be an edit button on the object line here:
    screenshot from 2018-04-16 13-28-20
    When clicked, the key should become a text box, with save/cancel buttons following it (you don't need the type confirmation button that values have, since it's always a string)

  • When editing a value, the key should also become editable, i.e. here there should be two text boxes, not one:
    screenshot from 2018-04-16 13-28-32
    (But I think you still only need the one set of save controls - you could save/cancel them together, that's fine)

@brentluna
Copy link

brentluna commented Aug 14, 2018

Any update on this? In terms of UX, it would seem the most logical would to just have the same edit button inline w/ the key that would be edited. That same set of buttons has a delete button, that deletes the key, which makes me feel like a button to edit, would fit there.

@sushantarsenal
Copy link

In the current version, is it possible to replace the textbox with a dropdown(with a list of my own options to select from) while trying to edit values?
screen shot 2018-09-18 at 12 42 14 pm
For example, in this case, I would like to open a dropdown(with Male and Female options) instead of a textbox.

@mateosilguero
Copy link

I made a solution for this here: #233

@rathish
Copy link

rathish commented Nov 23, 2018

In the current version, is it possible to replace the textbox with a dropdown(with a list of my own options to select from) while trying to edit values?
screen shot 2018-09-18 at 12 42 14 pm
For example, in this case, I would like to open a dropdown(with Male and Female options) instead of a textbox.

I created quick solution, to render textarea or select based initiValues property. check

@hari4125862
Copy link

Hey any update on the about feature?

@sriramarunachalam
Copy link

Is there any update on this issue?

@mnavon
Copy link

mnavon commented Aug 17, 2020

Is there any update on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants