Skip to content

Commit

Permalink
move todos
Browse files Browse the repository at this point in the history
  • Loading branch information
erikng committed May 24, 2024
1 parent 34cd108 commit 585712f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions Nudge/3rd Party Assets/sofa.swift
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ class SOFA: NSObject, URLSessionDelegate {
let session = URLSession(configuration: config, delegate: self, delegateQueue: nil)
request.addValue("\(Globals.bundleID)/\(VersionManager.getNudgeVersion())", forHTTPHeaderField: "User-Agent")
request.setValue(lastEtag, forHTTPHeaderField: "If-None-Match")
// TODO: I'm saving the Etag and sending it, but due to forcing this into a syncronous call, it is always returning a 200 code. When using this in an asycronous method, it eventually returns the 304 response. I'm not sure how to fix this bug.
var attempts = 0

var responseData: Data?
Expand Down
1 change: 0 additions & 1 deletion Nudge/UI/Main.swift
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ class AppDelegate: NSObject, NSApplicationDelegate {
// TODO: Add more logging to "unsupported devices" UI.
// TODO: Add localization for "unsupported devices" text fields
// TODO: Get someone to update JAMF JSON schema for all the new keys and wiki
// TODO: check the sofa json etag even after the timelimit age to reduce more bandwidth
if OptionalFeatureVariables.utilizeSOFAFeed {
var selectedOS: OSInformation?
var foundMatch = false
Expand Down

0 comments on commit 585712f

Please sign in to comment.