From 585712feeb19c03cd2f8fa78ca25af1ccad912a8 Mon Sep 17 00:00:00 2001 From: Erik Gomez Date: Fri, 24 May 2024 13:14:53 -0500 Subject: [PATCH] move todos --- Nudge/3rd Party Assets/sofa.swift | 1 + Nudge/UI/Main.swift | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/Nudge/3rd Party Assets/sofa.swift b/Nudge/3rd Party Assets/sofa.swift index 22f82afc..cee37fde 100644 --- a/Nudge/3rd Party Assets/sofa.swift +++ b/Nudge/3rd Party Assets/sofa.swift @@ -231,6 +231,7 @@ class SOFA: NSObject, URLSessionDelegate { let session = URLSession(configuration: config, delegate: self, delegateQueue: nil) request.addValue("\(Globals.bundleID)/\(VersionManager.getNudgeVersion())", forHTTPHeaderField: "User-Agent") request.setValue(lastEtag, forHTTPHeaderField: "If-None-Match") + // TODO: I'm saving the Etag and sending it, but due to forcing this into a syncronous call, it is always returning a 200 code. When using this in an asycronous method, it eventually returns the 304 response. I'm not sure how to fix this bug. var attempts = 0 var responseData: Data? diff --git a/Nudge/UI/Main.swift b/Nudge/UI/Main.swift index 2becefb7..aaba5f0e 100644 --- a/Nudge/UI/Main.swift +++ b/Nudge/UI/Main.swift @@ -175,7 +175,6 @@ class AppDelegate: NSObject, NSApplicationDelegate { // TODO: Add more logging to "unsupported devices" UI. // TODO: Add localization for "unsupported devices" text fields // TODO: Get someone to update JAMF JSON schema for all the new keys and wiki - // TODO: check the sofa json etag even after the timelimit age to reduce more bandwidth if OptionalFeatureVariables.utilizeSOFAFeed { var selectedOS: OSInformation? var foundMatch = false