Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial install #16

Open
GaryWenneker opened this issue Aug 26, 2018 · 5 comments
Open

Initial install #16

GaryWenneker opened this issue Aug 26, 2018 · 5 comments

Comments

@GaryWenneker
Copy link

running the sample does not work:

Swapi

Error :(

maybe a good idea to add some comments to the readyme how to set up things (e.g. install with yarn does not work either because modules are missing and which are added with npm)

@marcveens
Copy link
Member

The project was created using npm, so try using that. Hence the missing yarn.lock file :)

@mlouage
Copy link
Contributor

mlouage commented Aug 27, 2018

Npm is fine. With npm 6, I don't really see a use case for yarn anymore. Yarn solved a speed and performance problem back when we had npm 4. But npm really caught up.

So yes, sticking with npm is good enough.

@marcveens
Copy link
Member

It seems that the .env file is missing because it's in the .gitignore file. We're looking into it

@mlouage
Copy link
Contributor

mlouage commented Aug 27, 2018

.env is supposed to be ignored. Best practice is to include a .env.sample so the person who pulls the repo can create a .env based on sample data.

@marcveens
Copy link
Member

marcveens commented Aug 27, 2018

PR #17 is added in order to fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants