-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial install #16
Comments
The project was created using npm, so try using that. Hence the missing yarn.lock file :) |
Npm is fine. With npm 6, I don't really see a use case for yarn anymore. Yarn solved a speed and performance problem back when we had npm 4. But npm really caught up. So yes, sticking with npm is good enough. |
It seems that the .env file is missing because it's in the .gitignore file. We're looking into it |
.env is supposed to be ignored. Best practice is to include a .env.sample so the person who pulls the repo can create a .env based on sample data. |
PR #17 is added in order to fix this issue |
running the sample does not work:
Swapi
Error :(
maybe a good idea to add some comments to the readyme how to set up things (e.g. install with yarn does not work either because modules are missing and which are added with npm)
The text was updated successfully, but these errors were encountered: