Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Werror -Wshadow compiler flag #531

Open
vaezim opened this issue Nov 17, 2024 · 3 comments
Open

Add -Werror -Wshadow compiler flag #531

vaezim opened this issue Nov 17, 2024 · 3 comments

Comments

@vaezim
Copy link

vaezim commented Nov 17, 2024

-Werror -Wshadow is a common flag in most projects. IXWebSocket cannot be built with this flag.
@bsergean
Copy link
Collaborator

bsergean commented Dec 7, 2024

Do you want to make a PR to fix this ?

@vaezim
Copy link
Author

vaezim commented Dec 8, 2024

Ok, I'll try.

vaezim added a commit to vaezim/IXWebSocket that referenced this issue Dec 8, 2024
@vaezim
Add -Werror -Wshadow compiler flags to CMAKE_CXX_FLAGS (machinezone#531
0dcbe5b 
)
@vaezim
Copy link
Author

vaezim commented Dec 8, 2024

Created the PR

vaezim added a commit to vaezim/IXWebSocket that referenced this issue Dec 8, 2024
@vaezim
Add -Werror -Wshadow compiler flags to CMAKE_CXX_FLAGS (machinezone#531
56e0303 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsergean @vaezim