Send email on commit (#355)

* send email on commit

* adopt test class to on_commit, see: https://stackoverflow.com/q/42585224/

* missing setting fix

registration/models.py

@@ -187,8 +187,12 @@ def create_inactive_user(self, site, new_user=None, send_email=True,
             registration_profile = self.create_profile(
                 new_user, **profile_info)
 
-        if send_email:
-            registration_profile.send_activation_email(site, request)
+            # send email only if desired and transaction succeeds
+            if send_email:
+                transaction.on_commit(
+                    lambda: registration_profile.send_activation_email(
+                        site, request)
+                )
 
         return new_user
 

registration/tests/default_backend.py

@@ -3,7 +3,7 @@
 from django.conf import settings
 from django.contrib.auth.models import AnonymousUser
 from django.core import mail
-from django.test import TestCase
+from django.test import TransactionTestCase
 from django.test.client import RequestFactory
 from django.test.utils import override_settings
 from django.urls import reverse
@@ -16,7 +16,7 @@
 
 @override_settings(ROOT_URLCONF='test_app.urls_default',
                    ACCOUNT_ACTIVATION_DAYS=7)
-class DefaultBackendViewTests(TestCase):
+class DefaultBackendViewTests(TransactionTestCase):
     """
     Test the default registration backend.
 

registration/tests/models.py

@@ -11,7 +11,7 @@
 from django.core import mail
 from django.core import management
 from django.core.exceptions import ImproperlyConfigured
-from django.test import TestCase
+from django.test import TransactionTestCase
 from django.test import override_settings
 from django.utils import six
 from django.utils.timezone import now as datetime_now
@@ -27,7 +27,7 @@
                    REGISTRATION_DEFAULT_FROM_EMAIL='[email protected]',
                    REGISTRATION_EMAIL_HTML=True,
                    DEFAULT_FROM_EMAIL='[email protected]')
-class RegistrationModelTests(TestCase):
+class RegistrationModelTests(TransactionTestCase):
     """
     Test the model and manager used in the default backend.
 

test_app/settings_test.py

@@ -60,3 +60,5 @@
     ('admin1', '[email protected]'),
     ('admin2', '[email protected]'),
 )
+
+ACCOUNT_ACTIVATION_DAYS = 7