Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modular config flow #31

Closed
madmachinations opened this issue Dec 12, 2024 · 3 comments
Closed

Modular config flow #31

madmachinations opened this issue Dec 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@madmachinations
Copy link
Owner

Hi guys, once again sorry for my absence. At work for this time of year there are always lots of pressing deadlines for the end of the year, and that combined with christmas-y stuff usually sucks up all my time.

Not forgotten about all this, I also have some issues with the integration as it stands on my own rig. I have been thinking about how best to tackle all your various issues in one sweeping change, and I have decided the best approach is to turn all the scraping code into a series of modules which can be reconfigured.

So basically, there would be a json file for say the Italian version or the US version. And this file will just say in what order to run each of the modules, and with what arguments. Such as checking things like the remember me box.

Taking this approach will mean separate documentation can be written for how to write your own configs, as no code would have to be touched. This documentation could also form the basis of a sort of setup wizard in the client. Whereby if no config is working for you, you could be guided through creating one with a series of questions.

This would also make it much easier for all of you too be able to merge in your configs for all of your various regions, and make them available to everyone else.

Which config to use would be automatically picked based on the domain of the regional instance the user is trying to access. So accessing amazon.it would use the italian one, etc. If no specific config exists, then it would fall back.

I will work on adding this over the weekend. It should be able to get the functional changes done and the documentation written, but no config wizard thing. But this should be enough to resolve most of the open issues at this point. I will add some configs to cover all the open issues.

@nickiles
Copy link

How did you get on?

@madmachinations madmachinations added the question Further information is requested label Jan 4, 2025
@madmachinations
Copy link
Owner Author

Currently not sure if this is necessary. I did a bunch of checks on a few different versions of amazon around the world and only found one inconsistency so far.

I will keep this issue open in case anything new appears, but if not this will be closed off as redundant in time

@madmachinations
Copy link
Owner Author

This can go, I have a better idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants