Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency on Tag 1.2.1 #34

Closed
fpastana opened this issue Aug 15, 2023 · 1 comment
Closed

Inconsistency on Tag 1.2.1 #34

fpastana opened this issue Aug 15, 2023 · 1 comment

Comments

@fpastana
Copy link

fpastana commented Aug 15, 2023

Hello guys,

I just realized that version 1.2.1 on Packagist says Madzipper is compatible with PHP ^7.3 when it accepts only PHP 7.4 or above.

As for what I've seen, the only issue that makes it to be incompatible with PHP 7.4 is the fact the class ZipRepository has a typed property called $open. PHP 7.3 does not accept these typed variables yet, but only PHP 7.4 or above.

public bool $open = false;

It could be great to fix this minor detail =).

Sincerely,
Felipe Pastana.

@repl6669
Copy link
Collaborator

repl6669 commented Apr 5, 2024

Hello, fixed by #42. Sorry, I did not have to get to this earlier.

@repl6669 repl6669 closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants