Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js - CITGM: npm test fails on s390x system architecture. #20

Open
pacostas opened this issue Jul 18, 2022 · 1 comment
Open

Node.js - CITGM: npm test fails on s390x system architecture. #20

pacostas opened this issue Jul 18, 2022 · 1 comment

Comments

@pacostas
Copy link

Blake2b-wasm is inlcuded in Node.js citgm https://github.com/nodejs/citgm/blob/ab4480422009a60926ec1810e29cc6361437d167/lib/lookup.json#L61-L64 , a tool for testing Node.js packages ecosystem before each Node.js release. I work with the Node.js team and they are trying to increase test coverage for Node.js. One of their requests is to increase test coverage on s390x systems using blake2b-wasm module. Unfortunately blake2b-wasm fails on s390x systems due to outdated esbuild version on wasm-tools, a dependency of blake2b-wasm. In order to fix that, wasm-tools has to upgrade esbuild to its latest version. I'm willing to open a PR on wasm-tools but I cant find their github repo. I see that at least one of the collaborators of blake2b-wasm is also a collaborator on wasm-tools. I would really appreciate if you could point me to the github repo on wasm-tools to open a PR for upgrading esbuild and then open a PR on blake2b-wasm for upgrading wasm-tools.

@pacostas
Copy link
Author

pacostas commented Aug 2, 2022

Opened PR #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant