From 954892c1045eeddc4a01fe978b4ad217da4bf172 Mon Sep 17 00:00:00 2001 From: chuccv Date: Tue, 23 Nov 2021 15:29:34 +0700 Subject: [PATCH 1/2] [Fix Bug] Popup not showing when setting "Exclude Page(s) with URL contains". --- Block/Popup.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Block/Popup.php b/Block/Popup.php index 3d0723c..94b148a 100644 --- a/Block/Popup.php +++ b/Block/Popup.php @@ -218,7 +218,7 @@ public function checkExcludePaths() $pathsUrl = array_map('trim', $arrayPaths); foreach ($pathsUrl as $path) { - if (strpos($currentPath, $path) !== false) { + if (!empty($path) && strpos($currentPath, $path) !== false) { return false; } } From 7921a79c9edbf0f878af617dbe7ae94d1fa8faf2 Mon Sep 17 00:00:00 2001 From: Brian Date: Wed, 13 Jul 2022 16:08:48 +0700 Subject: [PATCH 2/2] Clean code --- composer.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/composer.json b/composer.json index 627fa6c..584c0d7 100644 --- a/composer.json +++ b/composer.json @@ -2,10 +2,10 @@ "name": "mageplaza/module-better-popup", "description": "Magento 2 Better Popup", "require": { - "mageplaza/module-core": "^1.4.5" + "mageplaza/module-core": "^1.4.12" }, "type": "magento2-module", - "version": "1.2.3", + "version": "1.2.4", "license": "proprietary", "authors": [ {