-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS universal binary #40
Comments
just tried to use CMake GUI press "Add Entry" and then set Name to CMAKE_OSX_ARCHITECTURES, Type=String, Value=arm64;x86_64
|
just tried : |
Hi @amay5267, The problem is that CMake is finding the Can you make the following change to # Optional dependencies
find_library(MAGIC magic)
if (MAGIC)
target_link_libraries(${TURBO}-core PRIVATE ${MAGIC})
target_compile_definitions(${TURBO}-core PRIVATE HAVE_MAGIC)
+ find_path(MAGIC_INCLUDE "magic.h")
+ if (MAGIC_INCLUDE)
+ target_include_directories(${TURBO}-core PRIVATE "${MAGIC_INCLUDE}")
+ else()
+ tv_message(FATAL_ERROR "'magic' development headers not found")
+ endif()
endif() If it doesn't, can you try adding the |
Hi @magiblot I have installed libmagic over homebrew. |
Is there a symlink in |
|
Please use code blocks (```) when pasting log output. This is the issue:
You are building Turbo for arm64, but the dependencies |
What did you do to make it work? |
arch -arm64 brew install libmagic ncurses |
And what fixed the |
Probaly coping 'magic.h' file from /usr/local/Cellar/libmagic/5.43/include/magic.h to /Users/usr/Documents/turbo/turbo/source/turbo-core/ |
Hi @onderweg |
As far as I remember, I never build a universal binary. (For the Intel build to succeed, I had to add |
Hi @onderweg |
x86_64-turbo.zip lipo -create arm64-turbo x86_64-turbo -output universal-turbo $ file universal-turbo |
I take note of that, thanks. |
Mmm, my build is dynamically linked to a specific ncurses version. So maybe not really portable?
|
I also managed to build an universal binary with: cmake . -DCMAKE_BUILD_TYPE=Release -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" && 20:21:02
cmake --build . Check output architecture:
Linked libraries:
|
Apple Silicon up to Ventura is supported in pkg-config --cflags --libs You can see that the Thanks for including the binary output as well, cheers |
Hi @magiblot @stuaxo
I have Xcode 12.2 ready to produce macOS universal binary.
any idea how to build macOS universal binary from Turbo?
Can you please update CMake files with something like CMAKE_OSX_ARCHITECTURES=arm64;x86_64
?
The text was updated successfully, but these errors were encountered: