Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallets data keys is not transformed and have discrepancy with types #118

Open
serhiislobodian opened this issue Nov 8, 2023 · 0 comments

Comments

@serhiislobodian
Copy link

βœ… Prerequisites

  • [+] Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • [+] Are you running the latest SDK version?
  • [+] Are you reporting to the correct repository (@magic-sdk/admin)?

πŸ› Description

data.wallet keys are not transformed like the rest

https://github.com/magiclabs/magic-admin-js/blob/master/src/modules/users/index.ts#L73

Type definitions point to the address property that should be called publicAddress but in reality, it is public_address

πŸ€” Expected behavior

Correct type definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant